Replace _ with + when verifying the chart version matches the OCI artifact tag
#1102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baburciu
force-pushed
the
accept-underscore-ocirepo-tag-hr
branch
2 times, most recently
from
adcbcaf to
b2db396
Compare
|
I'm not sure what should be best returned as error return "", fmt.Errorf("failed parsing artifact revision %s", tagD[0])or return "", fmt.Errorf("failed parsing artifact revision %s", tagConverted)but the conversion needs to happen prior to calling |
|
I think we should return the one with a PS. This PR needs a test using a tag that has |
baburciu
force-pushed
the
accept-underscore-ocirepo-tag-hr
branch
from
b2db396 to
08cb29c
Compare
Signed-off-by: Bogdan-Adrian Burciu <[email protected]>
baburciu
force-pushed
the
accept-underscore-ocirepo-tag-hr
branch
from
08cb29c to
caf49d2
Compare
|
thank you, I've added a test for it, which is passing |
stefanprodan
changed the title
_ with + when verifying the chart version matches the OCI artifact tag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1099
OCI tags are not semver compatible, with
+character not allowed. Helm worked around this by converting+to_before pushing to the OCI repo and vice versa when pulling from the repo.This PR makes helm-controller adhere to that convention, by converting OCI artifact tag using
_to+replacement prior to any check or processing.